Pressing "Clear All" button on "Import Annotations" dialog does not remove ticks from checkboxes
Closed this issue · 2 comments
After doing a fetch annotations, the "Import Annotations" list is displayed. This has a list of the books that annotations have been found for. At the beginning of each line, there is a checkbox with a tick in it. There is also a "Clear All" button under the list. Pressing the "Clear All" button does not appear to do anything except changing the text of the button to "Set All". But, when anything is done to change the list, the other checkboxes are cleared. The anything includes clicking on a line or resizing the window.
The reverse happens when the "Set All" button is pressed. The checkboxes are not ticked until something else causes a repaint.
This is with:
calibre 1.17.0
Windows 7 32 bit
English language
Annotations plugin 1.3.0.
I've pulled the code down and done some testing. The change for this bug didn't work. I had a little look at the rest of the code. The last line of "toggle_confidence_colors" is:
self.tm.refresh(self.show_confidence_colors)
Putting that at the end of "toggle_checkmarks" instead of the repaint and processEvents seems to work. But, I am not sure if there are any side affects.
I've pushed another update to the source repo with your suggested changes. This must be a Qt platform issue, as the original code worked for me on OS X. Your change works equally well for me. I'll close this issue as it should be resolved.