davidhu2000/react-spinners

PuffLoader has zero size

sgehrman opened this issue · 1 comments

sgehrman commented

I'm on .12 but I think the latest has the same issue.

<PuffLoader size={45} color="#ccc" />

The spinner is wrapped in a span and has zero height/width and draws outside it's bounds.
If I change the span to a div it works.

davidhu2000 commented

react-spinners/src/PuffLoader.tsx

Lines 20 to 21 in c54d1a5

const wrapper: React.CSSProperties = {
display: "inherit",

the display property inherits from the parent, so if you wrap this in a span, it'll act like the span.

I don't think this is a real issue as this is by design.