davidjrh/dnn.azureadprovider

Question: Does this module work with the PKCE flow

Rodien opened this issue 2 years ago · 1 comments

Rodien commented 2 years ago

Hi David,

Does this module work with the PKCE flow?

Have you tried this before?

davidjrh commented 2 years ago

Not currently, but seems that would be easy to add support by specifying the code_chanllenge parameters described at https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-auth-code-flow#request-an-authorization-code when requesting an authorization code, that should be added after this line https://github.com/davidjrh/dnn.azureadprovider/blob/master/DotNetNuke.Authentication.Azure/Components/AzureClient.cs#L625

Do you feel comfortable of implementing the modification and doing a PR?