davidosomething/duotone-base16

Background is bright red for Simurai's duotone themes in gnome-terminal

nerdenough opened this issue · 2 comments

nerdenough commented

When converting Simurai's duotone themes (tried default and dark-earth), base00 is #FF0000, leading to the background of gnome-terminal being bright red after creating the theme through base16-builder or base16-builder-php.

image

davidosomething commented

want to submit a PR? I'm not sure what it should map to:
https://github.com/davidosomething/duotone-base16/blob/master/db16#L102-L105

  • 👍1
nerdenough commented

Just submitted a PR that seems to fix the issue - though I am not sure how it will impact other templates if the #FF0000 and #FFFF00 are being used by them.