Seeking co-maintainers!
davidtheclark opened this issue · 24 comments
I've been shifting my focus away from UI development, so don't plan on addressing new issues myself. If you use this library and want to see development continue, you can make that happen by becoming a co-maintainer — with permissions to triage issues, merge PRs, cut releases, etc.
Please comment below if you're interested!
Another possibility is for a dedicated owner to fork this code and create a new package. I'd be happy to link to that library from the README of this one.
What a pity. I've created my focus-lock to provide some alternative to your one, and just recommended focus-trap as a solution for one issue, as long as behavior or your approach was better fitting their needs.
Still valid? Maybe I could help here.
Sure, @jtomaszewski. I'll add you as a GH collaborator.
Would you be able to release a 5.0.1 to npm ? ;]
@jtomaszewski There was already a 5.0.1 published — not sure what was up with that — so I published 5.0.2.
🤚 @davidtheclark could I get collaborator here as well? Trying to do a synced update across the chain to react-aria-modal 😄
I'd be happy to help as well!
@davidtheclark I'm very curious to see if you have any roadmap of the possible features to rollout for this. That way, it might become easier for other interested people to know if they can lend in a hand.
I've got a few ideas for immediate work here and in focus-trap-react and react-aria-modal
- update dependencies in all (also my suggestion switch to
yarn) - modernize build process with rollup
- add tests here using jest + testing-library/dom by converting examples
- update dependencies on
focus-trapandfocus-trap-reactup the chain
Hi all! I created an alternative for this lib
https://github.com/valu-digital/focus-trap
The main motivation creating it was the multi-container support which is a must have for our product.
It's pretty fresh release so it's probably buggier than this one ATM but bug reports welcome :)
I also wrote some tests for it using Cypress but that appear to be really hard kuceb/cypress-plugin-tab#10
@davidtheclark so I noticed something now that I'm trying to do maintaining. I'll need to be able to publish to npm for the packages (focus-trap, focus-trap-react, react-aria-modal, and react-displace [lol also need contrib access to react-displace now too]) to get updates across the chain & clean up the react 16 warnings.
@wldcordeiro 🆗 permissions are now assigned.
I'd like to co-maintain it :)
@davidtheclark could you add @realredallen to your list of editors? He is on my team and could release the update.
@davidtheclark could you add @realredallen to your list of editors? He is on my team and could release the update.
@nicolethoen Looks like that's not a valid GitHub username. Is there a typo?
Hi, I'm who @nicolethoen mentioned. My github is @redallen and my npm user is @realredallen.
I'm happy to be a co-maintainer.
@davidtheclark Given the inter-dependence of this library with tabbable and focus-trap-react, what do you think about moving this repo to the https://github.com/focus-trap org where we've already moved focus-trap-react? We have focus-trap/focus-trap-react#87 now which I believe should really be a feature in focus-trap, and moving the repo there would allow me to address that. I'd still keep this issue open for maintainers, though!
@davidtheclark Thanks for moving the repo over!
@davidtheclark Did you happen to give @maraisr and myself NPM publish rights at the same time you moved the repo over? #120 will need publishing once merged, since we want to get that into focus-trap-react.
@davidtheclark Did you happen to give @maraisr and myself NPM publish rights at the same time you moved the repo over? #120 will need publishing once merged, since we want to get that into
focus-trap-react.
@davidtheclark Wondering about this ^^^
@stefcameron Added you as a maintainer of both focus-trap and tabbable. I believe you can then add other co-maintainers.
@davidtheclark Thank you!
Closing this. Seems like I'm running the show now. 😅