Solcast integration with `delta_forecast` > 1 fails
toggm opened this issue · 3 comments
Describe the bug
Using solcast
forecast model together with delta_forecast
set to value > 1 fails with:
ERROR - Not enough data retrived from SolCast service, try increasing the time step or use MPC
EMHASS installation type
- Docker Standalone
Additional context
Without testing or adjust, IMO problem comes from the fixed time frame when calling the API:
Line 238 in d06b829
Value of hours
should be a factor of delta_forecast
to be compatible with the expected number of results. As far as I could see requests are not limited to 24 hours only. Otherwise startup of app should already fail in case of invalid configuration parmeters.
Hi. Yes you are right, this is hard coded to retrieve just 24h of data.
Yes we could make it a function of the passed delta_forecast
.
But then we need to know what is the maximum possible period to retrieve data from SolCast.
We need to check that on the SolCast API.
Solved in the just released new version.
Closing this for now but reopen if eneded.