dbcli/athenacli

Running athenacli without configuration changes causes visible Exception

jashgala opened this issue · 4 comments

When I don't set the values of the AWS configuration parameters, there is an exception thrown in the console causing the CLI to exit.

Perhaps it would be better to have an exception handling routine to handle this scenario. Maybe something similar to what we are trying to do in #15

At the very least, it would be great to avoid the exception by showing an error message.

missing configuration throws exception

zzl0 commented

Thanks for this issue. Yes, it'd be better to have an exception handling routine to handle this scenario. But I am not sure which way is better:

  1. Just print an error message and ask users to change the config file.
  2. Try to recover from it (like, show a prompt and let users input the values).

What do you think?

(2) would perhaps be better UX than (1)

In the short term, we can do (1) as an immediate fix. I'll write up a patch for this.

Perhaps when we are solving #15, we can see if it can be implemented in a way where (2) can be supported out of the box.

zzl0 commented

@jashgala fixed in #20

zzl0 commented

👍Nice work.