deanpcmad/sidekiq-limit_fetch

Redis deprecation notice

bgwilson87 opened this issue · 9 comments

bgwilson87 commented

redis.multi do
redis.get("key")
end

should be replaced by

redis.multi do |pipeline|
pipeline.get("key")
end

(called from /Users/me/.rvm/gems/ruby-2.7.4/bundler/gems/sidekiq-limit_fetch-bf9cee3b81e4/lib/sidekiq/limit_fetch/global/monitor.rb:49:in `block in update_heartbeat'}
Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

yrashk commented

Same here.

iurev commented

I submitted a new pull request fixing this issue:
#124

Another temporary way to fix this warning would be to downgrade to redis v4.5.1 where multi method works as usual. link

rgaufman commented

Please merge, we are seeing this as well

frantisekrokusekpa commented

Same here guys!

mkolenda commented

Same here too. Thanks for fixing.

rgaufman commented

Any update please?

iurev commented

Unfortunately, this project is not currently supported and is looking for a new maintainer https://github.com/brainopia/sidekiq-limit_fetch/issues/106

As a temporary option, you may use version from my pull-request in your Gemfile.

But beware, fetching gems directly from a stranger's github is an insecure practice.

gem 'sidekiq-limit_fetch',
  git: 'https://github.com/iurev/sidekiq-limit_fetch',
  branch: 'feature/fix_deprecated_redis_multi'
deanpcmad commented

Hey, I've now taken over this project and gem. I'll be going through the pull requests and issues in the next week or two :)

  • 👍1
  • ❤️1
deanpcmad commented

This has been fixed with #124 - I'll try and get a release done this weekend

  • 👍1