decaf-dev/obsidian-dataloom

Table Cell content gets deleted after creating a new row

kbonnici opened this issue · 5 comments

kbonnici commented

Describe the bug

Pressing + New button creates a new row as expected, but around half a second later any content that has been typed into that row is deleted.

Steps to reproduce

  • Click + New button to add new row to data loom table
  • Type into any of the cells in the new row
  • Half a second later, whatever content was typed is automatically removed

Expected behavior

Immediately entering a cell and typing should preserve whatever I type

Are you using the mobile app?

No

Obsidian debug info

SYSTEM INFO:
Obsidian version: v1.5.3
Installer version: v1.5.3
Operating system: Darwin Kernel Version 23.2.0: Wed Nov 15 21:53:18 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T6000 23.2.0
Login status: not logged in
Insider build toggle: off
Live preview: on
Base theme: adapt to system
Community theme: Minimal v7.4.5
Snippets enabled: 0
Restricted mode: off
Plugins installed: 9
Plugins enabled: 9
1: Minimal Theme Settings v7.3.1
2: Calendar v1.5.10
3: Excalidraw v2.0.13
4: Dataview v0.5.64
5: Advanced Tables v0.20.0
6: Highlightr v1.2.2
7: DataLoom v8.15.10
8: Paste URL into selection v1.7.0
9: Iconize v2.8.1

RECOMMENDATIONS:
Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Relevant log output

handleNewRowClick
plugin:notion-like-tables:46914 App handleClick
plugin:notion-like-tables:46914 MenuProvider clearMenuTriggerFocus
plugin:notion-like-tables:46914 LoomStateProvider saving state to disk!
plugin:notion-like-tables:46914 updateRowsFromSources called
kbonnici commented

I suspect the culprit is updateRowsFromSources or some other higher level function call.

I asked about this behaviour on reddit and someone commented saying that Obsidian released an update recently which made some changes to the way tables are handled. Perhaps that is a good place to start.

jboulter11 commented

I'm having a similar issue. updateRowsFromSources is getting called and disrupting table editing of any kind, reverting changes as they're being made. Turning off advanced tables does seem to stop the updateRowsFromSources call from disrupting editing. However, I'm noticing that sometimes the table just locks up entirely and I have to reload the note to be able to edit or scroll again even with Advanced Tables off. Maybe related, maybe not?

My debug info:

SYSTEM INFO:
	Obsidian version: v1.5.3
	Installer version: v1.4.16
	Operating system: Windows 10 Pro 10.0.22621
	Login status: logged in
	Catalyst license: none
	Insider build toggle: off
	Live preview: on
	Base theme: dark
	Community theme: Minimal v7.1.2
	Snippets enabled: 1
	Restricted mode: off
	Plugins installed: 27
	Plugins enabled: 26
		1: Excalidraw v2.0.2
		2: Advanced Tables v0.19.1
		3: Dataview v0.5.64
		4: Calendar v1.5.10
		5: Advanced Slides v1.20.0
		6: Templater v1.18.1
		7: Tasks v5.1.0
		8: Style Settings v1.0.7
		9: QuickAdd v1.6.0
		10: Tag Wrangler v0.6.1
		11: Iconize v2.8.0
		12: Editor Syntax Highlight v0.1.3
		13: Natural Language Dates v0.6.1
		14: Emoji Shortcodes v2.2.0
		15: Periodic Notes v0.0.17
		16: Recent Files v1.3.8
		17: Remotely Save v0.3.25
		18: Reminder v1.1.15
		19: Minimal Theme Settings v7.3.0
		20: Note Refactor v1.8.2
		21: Hider v1.3.1
		22: Book Search v0.5.11
		23: Linter v1.20.1
		24: Buttons v0.4.19
		25: Smart Connections v1.6.37
		26: DataLoom v8.15.10

RECOMMENDATIONS:
	Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.
jboulter11 commented

Ah, when the table fully locks up I do seem to see two updateRowsFromSources calls showing up when it happens. Here's what I see logged when the lockup happens with Advanced Tables disabled:
image

kbonnici commented

The problem still occurs even with all other plugins disabled. I dont experience this locking behaviour you describe though.

When i get a chance i will test with a fresh install of obsidian and report back.

decaf-dev commented

Sorry I have been busy for the holidays. Will look into this

  • 👍1