Long post titles can lead to invalid hostnames in Netlify deploy previews

Question

Long post titles can lead to invalid hostnames in Netlify deploy previews

Opened this issue 7 years ago · 6 comments

- Do you want to request a feature or report a bug?

bug

- What is the current behavior?

CMS entries for posts with long titles can create branch names too long for deploy previews via Netlify's standard branch deploy naming scheme. DNS hostnames can be a maximum of 64 characters per "segment" so "a-very-long-blog-post-title-because-i-am-a-really-really-wordy-dude--sitename.netlify.com" will not be a usable hostname and thus the URL will fail to load with various/unspecified bad behavior.

- If the current behavior is a bug, please provide the steps to reproduce.

create a post with a title longer than 64 characters and attempt to load the branch deploy from the deploys tab in Netlify's UI

- What is the expected behavior?

Branch deploys would be loadable by their normal hostname, branchname--sitename.netlify.com . Since there is no way for the CMS to know what "sitename" is there we should probably pick a short-ish cut-off like 40 characters - it won't solve EVERY situation but it will do better than the current which allows you to create an impossible branchname of >64 characters which will NEVER load properly (even for a sitename like 'a.netlify.com').

- Please mention your node.js, and operating system version.

Netlify default build (node v6.11.2 (npm v3.10.10)/ubuntu 14.04 x86_64) && CMS version 0.4.4

Answer 1 · 2017-08-17T15:07:14.000Z

Good point. Since we don't want to enforce Netlify-specific rules, is to allow a configurable max-length, and maybe set the default to something around 40.

Answer 2 · 2017-11-28T00:07:06.000Z

I really don't think we should do anything to the title here -- that's part of the content. I think the real thing that we should be looking at is keeping slugs and branch names shorter, not the title. Thoughts?

Although, many CMS's do limit title length, so it's not strictly a bad idea.

Answer 3 · 2017-11-28T17:09:45.000Z

quite agree, Caleb. I was not suggesting that we tell the author to respect some arbitrary boundary, but that we create branch names that can work well with our system.

…

On Mon, Nov 27, 2017 at 4:07 PM, Caleb ***@***.***> wrote: I really don't think we should do anything to the title here -- that's part of the content. I think the real thing that we should be looking at is keeping slugs and branch names shorter, not the title. Thoughts? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#526 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN-oA8sYSDNuxExd-LE90dOyBH1_sJSks5s606qgaJpZM4O309M> .

Answer 4 · 2018-09-13T12:02:55.000Z

@erquhart How it is related to design? I didn't get it.

Answer 5 · 2018-10-23T18:46:08.000Z

Design also encompasses architectural design.

Answer 6 · 2019-10-29T13:46:33.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.