decathorpe/mitmproxy_wireguard

`pip install --no-binary :all: mitmproxy-wireguard` fails

Closed this issue · 2 comments

mhils commented

https://crates.io/crates/x25519-dalek has recently shipped v2.0.0-rc.2, which includes a breaking change over the previous v2.0.0-pre.1 release. This causes pip install --no-binary :all: mitmproxy-wireguard to fail (see mitmproxy/mitmproxy#6045). Things seem to work for mitmproxy_rs because the sdist there includes Cargo.lock (and that is somehow take into account I guess), but it fails for mitmproxy-wireguard. Can we ship a quick patch release including Cargo.lock? :)

decathorpe commented

Huh, I'm not sure why the sdist doesn't include the Cargo.lock file ... I assumed it was included.

Looks like this is a known limitation of cargo / maturin:
PyO3/maturin#748 (reply in thread)

Anyway, since v2.0.0-rc.2 is not compatible with v2.0.0-pre.1, we need to pin to the latter anyway, so I'll do that, include Cargo.lock explicitly in the sdist, and publish a new release.