decentraland/dappeteer

MetaMask breaking change - no more global web3 object

hudsonburgess opened this issue · 2 comments

hudsonburgess commented

MetaMask just announced a breaking change, effective 2-Nov-2018

https://medium.com/metamask/https-medium-com-metamask-breaking-change-injecting-web3-7722797916a8

How is that going to affect this project?

cazala commented

dApps should still support old versions of MetaMask and/or browsers that inject web3, and since this package uses MetaMask v4.7.4 which injects web3, you can still use it. What we will probably do after MetaMask releases the opt-in feature is update the extension used by this package to the newer one, and add some method to accept the opt-in from the e2e tests, like:

const page = await browser.newPage()
await page.goto('http://my-dapp.com')
const loginButton = await page.$('#login')
await loginButton.click()
  
await metamask.confirmOptIn()
  • 👍5
cazala commented

dappeteer@0.4.0 works with metamask v5+