decentralized-identity/presentation-exchange

JSONSchema issue for 2.1: we are using later syntax?

Opened this issue · 5 comments

Some discussion out of IIW: concerns about JSON schema are related to test vectors used to test conformance. We use a more recent syntax that is perhaps difficult for some peoples' toolsets. Syntax might be $ref; need to confirm

If correct, this should be a simple fix for 2.1

@rado0x54 @andorsk @csuwildcat confirm this is blocking for 2.1 and get owner if so

possibly dropped? Could be referring to schemas in repo

Maybe this is the concern: https://json-schema.org/understanding-json-schema/structuring#dollarref

In Draft 4-7, $ref behaves a little differently. When an object contains a $ref property, the object is considered a reference, not a schema. Therefore, any other properties you put in that object will not be treated as JSON Schema keywords and will be ignored by the validator. $ref can only be used where a schema is expected.

here is an example this could be referring to. In 4-7, since $ref is in path_nested, type would be ignored by a validator.

Note the above example is recursive. But this is only a problem with a $ref referring to another $ref (source: https://json-schema.org/understanding-json-schema/structuring#recursion)

After discussion on Feb 29, 2024, we realized we can't reconstruct the concern coming out of IIW. Please provide context on what the concern with $ref was by March 15; otherwise we will close