deckgo/deckdeckgo

Dismiss low contrast warning

Zenahr opened this issue · 3 comments

Affected part of DeckDeckGo

  • Studio (online editor)
  • Remote control
  • Poll
  • Site
  • Documentation
  • Demo
  • Starter kit
  • Web Components
  • Templates

Feature Description

Add a Dismiss button to low contrast warnings that will make the warning disappear altogether.

Use Case

Evidently the low contrast warning pops up in cases where it shouldn't pop up. I would like to generally have an option to opt out of the warning since it is distracting while working on slides.

Additional Notes

This is a slide I've gotten the warning for:
image

upon clicking the Got it button the warning does not disappear.
image

Sure, that's totally doable!

In addition we should probably also add the option to the "settings > customization" so that the user can trigger it back to "active".

That being said, if the contrast warning popups when it should not, we should also in parallel try to fix these cases 😅.

Capture d’écran 2021-01-26 à 15 14 36

Indeed there was a bug in the contrast detection which followed a refactoring of the color picker. I solved it in PR #1094.
I keep an eye on it if it would need more fix.

Nevertheless, fix or not, this feature remains a good idea 👍

Solved by @christiankozalla

Will be released in v4.8.0 🥳