deckgo/deckdeckgo

lazy-img attributes img-height img-width don't work

flatmax opened this issue · 3 comments

flatmax commented

Affected part of DeckDeckGo

  • Web Components

Reproduction

Can' use img-width and img-height

Steps to reproduce:

  1.     <deckgo-lazy-img img-src=url img-width=50 img-height=60>        </deckgo-lazy-img>

Expected Behavior

The image to resize

Actual Behavior

The image doesn't resize

Environment

  • Browser(s): chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): linux
peterpeterparker commented

Did you inspect the shadowed dom, are the width and height applied?

As you can see in the component here

deckdeckgo/webcomponents/lazy-img/src/components/lazy-img/deckdeckgo-lazy-img.tsx

Line 299 in 00d532f

return <img alt={this.imgLoaded ? (this.imgAlt ? this.imgAlt : this.imgSrc) : ''} loading={this.loading} sizes={this.imgSizes ? this.imgSizes : undefined} intrinsicsize={this.intrinsicsize}
width and height should be set if the props are set.

flatmax commented

Oh ok - are you saing that the attributes img-width and img-height aren't working ? I should use the properties instead ?

peterpeterparker commented

Actually I'm saying these should work but asking if you had a look to the shadowed content to see if anything seems not to work as expected?