multi: Add Ledger support.
Closed this issue · 7 comments
As approved in the proposal we are adding ledger support to decrediton. This issue is intended to track those changes.
The goal is to have the ability to sign and send transactions, receive transactions, view transaction history and verify addresses associated with the Ledger in a new scene based heavily off of the current trezor flow.
Changes will be made in small increments with as many tests as possible. I would like to disable mainnet use until everything is well tested and refined.
One thing I am not sure of is a small ledger icon we will need to use. If anyone reading this can produce one without much effort please let me know.
TODO:
- add ledger backend methods
- remove tickets section from trezor and add warning to obtaining address screen about only using in p2pkh scripts.
- add new screens for ledger and hook those up to the ledger methods
- create the small ledger icon on the create/choose wallet page
- finalize (testing/debugging) and allow on mainnet
- make tests for LedgerActions.js methods using a device and the testnet decred app (time/funding permitting)
change log
2023-04-28 Add TODO checklist
2023-09-21 Check add ledger backend methods, create small ledger icon, and remove tickets section
I am currently adding a LedgerActions.js file in actions and a file in helpers that should work as a good base and hold all of the logic from the poc we intend to use.
we should an TODO for adding the icon.
we should an TODO for adding the icon.
Do you mean use a placeholder for now?
no i mean a todo here in this issue tasks list, but i see now it's already there
Ok! I have started on remove tickets section from trezor and add warning to obtaining address screen about only using in p2pkh scripts.
Sweet, I also started Create the small ledger icon on the create/choose wallet page, not that the icon is also
used in the main screen.
I don't guess we will have time to add the tests using a device. Hopefully can get the rest merged here soon...