ded/sink-test

toggle showing of a test result

Zhami opened this issue · 5 comments

Presently clicking on a test shows the test result. I thought it would be nice to click again to un-show.

I forked your sink-test and made some changes. Alas, I'm not facile with git and GitHub and don't know how to send a Pull Request for just the one change I made. You can see it here:
Zhami@f123654

ded commented

come to my repo, and click pull request at the top right-hand-side of the page

(1) I click the "pull request" from my repo, not yours.
(2) I knew to do that, but didn't (and still don't) know how to send a pull request for a specific commit -- that's the problem -- the pull request as issued contains two commits -- see my comment to the request
These matters of GitHub aside, you guys have done ad do fantastic work -- thanks!!

ded commented

hmmm.... i think you can create another branch based on your one now. then git checkout SHA123 to the previous state which it was good

I finally figured out how to do this. The key is to maintain a branch in sync with your master, then create a new branch, and into that git cherry-pick SHA1 to pull in specific commit(s). Then push the new branch. Which I have done, and have issued a pull request.

ded commented

Excellent. Ill have a look in the morning