deep-spin/understanding-spigot

error for lpsmap

Opened this issue · 7 comments

nanguoshun commented

Dear Tsvetomila,

Thanks for your work.

I am trying to install lpsmap from https://github.com/deep-spin/lp-sparsemap and have an error when I use it in sst/sparsemap.py

from lpsmap.ad3ext.parse import Parse
ModuleNotFoundError: No module named 'lpsmap.ad3ext.parse'

I first download the eigen as indicated in https://gitlab.com/libeigen/eigen and then perform the following scripts
export EIGEN_DIR=/path/to/eigen
python setup.py build_clib # builds ad3 in-place
pip install . # builds lpsmap and installs

My env is:
Unbuntu16.04
Python: 3.6
Pytorch: 1.6.0

I am not sure if the eigen should be compiled firstly.

Would you please give some suggestions?

Thanks a lot!

tsvm commented

Hi,

I just checked and it seems that there is some missing code, which I didn't consider earlier. We will be able to add it after January 4th. Until then, you can comment out line 4 in sparsemap.py and only try the methods that do not require SparseMAP. If you have any problems running the code for the other methods, please let me know.

I'm very sorry for not considering this and slowing you down. :(

Thanks a lot for your interest in our work and for pointing out this issue! It made me add more description in the README and some missing requirements. :)

Kind Regards,
Tsvetomila

nanguoshun commented

Hi Tsvetomila,

Thanks for your prompt response. Looking forward to your update for the SparseMax.

Happy Chrismas!

nanguoshun commented

Hi Tsvetomila,

May I know the plan to the update for the SparseMax? Thanks a lot!

tsvm commented

Hi,

Sorry for the late response! I will do my best to upload this by the end of the week.
There are some modifications I'm making in the use of the lp-sparsemap library, that's why it's taking me a bit more time than I first thought.

Kind Regards,
Tsvetomila

nanguoshun commented

Hi @tsvm , hope you are doing well. We are looking forward to the update of the code.

Would you please send it to my email for your draft version of code: nanguoshun@gmail.com

Thanks a lot!

tsvm commented

Hi,

I'm terribly sorry for the delay and for the inconvenience!

I just pushed some changes, with which SparseMAP should work, using the updated version of lp-sparsemap.

I will try to set up also for the NLI experiments to use it and will do my best to update it soon as well.

Let me know if you have issues with the SST ones.

P.S. When running the experiments, I had problems with versions of spacy and torchtext for loading the data. If you have problems with these, let me know.

Kind Regards,
Tsvetomila

tsvm commented

I pushed the changes for the NLI experiments as well, but I was still having issues with spacy when I tested them. I guess it was because I used a different version of spacy some months ago when I performed the experiments.
(This is the issue, however, the fix did not work for me: explosion/spaCy#4577)

Let me know if they work for you and with which version. Sorry I cannot be more precise, I will try again to fix it.