deepanshs/mrsimulator-app

Fit report does not populate on certain browsers

mgiammar opened this issue · 1 comments

After running a fit, the fit_report tab should update with tables displaying information about the fit. This functionality uses JavaScript and element.innerHTML to populate the page.

When mrsimulator-app is opened on Firefox, no issues arise. However on Safari and Google Chrome, the tab does not populate after a fit. Looking at the server output suggests the fit was successful and the issue arises from browsers' differences in JavaScript.

This issue probably stems from element.innerHTML.

Tying the update fit report callback to local-simulator-data instead of local-mrsim-data fixes the issue. local-simulator-data is updated later in the callback cycle allowing the fit-report string to be saved into a JavaScript variable before the update fit report callback is fired.