deepgram/deepgram-go-sdk

Fix API Key Ordering Precedence

Closed this issue 7 months ago · 1 comments

dvonthenen commented 8 months ago

What is the current behavior?

The API Key ordering or precedence is not correct. The order should be with first being the highest:

ClientOptions - https://github.com/deepgram/deepgram-go-sdk/blob/main/pkg/client/interfaces/types-client.go#L9
Input to New() functions - https://github.com/deepgram/deepgram-go-sdk/blob/main/pkg/client/prerecorded/client.go#L51
Environment Variable (DEEPGRAM_API_KEY)

This should match Python - https://github.com/deepgram/deepgram-python-sdk/blob/main/deepgram/client.py

Steps to reproduce

NA

Expected behavior

NA

Please tell us about your environment

NA

Other information

NA

dvonthenen commented 7 months ago

PR merged. Will be available on the next release.