Update path to istanbul assets

Question

Update path to istanbul assets

kof opened this issue 9 years ago · 12 comments

kof commented 9 years ago

Files like this one are moved in instanbul to assets dir.

zuul/node_modules/istanbul-middleware/node_modules/istanbul/lib/vendor/prettify.css

vvo commented 9 years ago

Allright

Answer 1 · 2015-10-26T00:58:21.000Z

@vvo ping, something from a recent update?

Answer 2 · 2015-10-26T22:02:38.000Z

@lpinca any hints? You did an istanbul related PR.

Answer 3 · 2015-10-26T22:03:02.000Z

Also @kof I am not sure to understand what you are asking for, can you be more specific on what's wrong?

Answer 4 · 2015-10-26T22:05:44.000Z

just install the latest version, remove node_modules and you will get it when you run some tests locally, it will try to load some files from a non-existing location.

Answer 5 · 2015-10-26T22:19:46.000Z

I still don't get how to fix this eheh. What to fix

Answer 6 · 2015-10-27T07:01:33.000Z

I can reproduce this and yes it is caused by the istanbul-middleware update (my pr).
If you pin down istanbul to version 0.2.x in instabul-middleware, it works. A newer istanbul generates this issue.

I will try to investigate as soon as I find some time.

To repoduce the issue:

Install latest zuul
Run zuul --local 8080 -- test.js
Open the url shown by zuul in a browser

Answer 7 · 2015-10-27T07:27:11.000Z

@vvo lets revert the update since it seems to break for users and needs more testing

Answer 8 · 2015-10-27T08:29:56.000Z

Ok published 3.7.2 with reverted istanbul-middleware, @lpinca would be good to get your insights when you have time :D

Answer 9 · 2015-10-27T08:30:58.000Z

@vvo sure, I will take a look, I just have to find a little time 😄

Answer 10 · 2015-10-27T14:39:47.000Z

gotwarlost/istanbul#467
gotwarlost/istanbul-middleware#26

istanbul-middleware@0.2.1 is broken, we have to wait for the next version.

Answer 11 · 2015-10-27T21:56:11.000Z

Nice, open a new PR when ready then :)