defuse/php-encryption

"decryptResourceInternal" method visibility public

kronthto opened this issue · 1 comments

kronthto commented

I was wondering, why is this public/exposed, all the other "Internal" methods appear to be private. I couldn't find external references to it. Just an oversight?

php-encryption/src/File.php

Line 457 in 9006087

public static function decryptResourceInternal($inputHandle, $outputHandle, KeyOrPassword $secret)

It's not a big problem though, and changing this risks breaking integrations in the wild that are using it directly now.

defuse commented

Good point, it indeed should have been private. Thanks!