Write unit tests for the code herein
arschles opened this issue · 7 comments
Important sections of this codebase are protected by sync.Mutex
es or sync.RWMutex
es, so special attention should be paid to writing concurrent tests (so that we can run go test -race
)
Punting to beta4
I'm moving this to RC1. Also note that I haven't looked at the state of the code or amount of coverage in unit tests yet. I just noticed that there are not many...
reclassifying as tests rather than a bug
@jchauncey would you be willing to take a crack at this or shall we punt to post-2.0?
i have tests in stdout-metrics that does a lot of what we want to test in logger i just need time to port them. but yeah we should just wait
@jchauncey Were said unit tests ever written? It looks like the logger had 70% coverage, though with recent refactors has fallen to 40%
This issue was moved to teamhephy/logger#7