Any thoughts on adding a ENV VAR or Flag to allow eviction of Daemon Sets
CAR6807 opened this issue · 5 comments
Line 70 in 5ee7675
Any thoughts on adding a ENV VAR or Flag to allow eviction of Daemon Sets?
I would like to cluster autoscaler to re-claim nodes but DS are still present on nodes
Sure. Always a question of use cases. In the ones I had been up against, we always ignored DaemonSets, so just kept the default. But no reason not to make it an option.
Hold on a moment, I don't understand. The way it is structured now, it ignores DaemonSets, which means it does reclaim the node if DS are present (it "ignored" DaemonSets). If you set it to false, it will not recall the node unless there are no DS present.
Isn't the current behaviour what you want, to ignore the DS?
Either way, no harm in the option.
No, I think you cleared it up. CA does reclaim the nodes even if DS are present. The very nature of the DS, it cannot be cordoned off or deleted from the node, even with Kube drain command. Regardless I appreciate you taking the time to look at this, I will close the issue.
No problem. I created the option anyways - if Kubernetes makes it an option, there is a reason for it - but I have a hard time seeing who would use it and when.