Merge Delta Connector code into this repo
tdas opened this issue · 4 comments
tdas commented
We have proposed for the Delta Connectors code to be merged in this repo. See more detailed in the Delta Connectors issue - delta-io/connectors#556
This issue is to track the work that needs to be done. I am thinking of breaking down the work as follows:
- Merge all the code (with full history) in a connectors/ directory - #1837
- Integrate the connector subproject to the main build.sbt so that they can all be compiled together with existing subprojects in this repo, and tested together - #1845
- Integrate unidoc, syntax check, mima binary compatibility check, etc.
kristoffSC commented
@tdas there is one PR missing for Flink connector - what would be action plan now, after #18237 is merged?.
Issue I've created: delta-io/connectors#561
PR that solves issue for original connectors repo: delta-io/connectors#559
tdas commented
The moving the change any connectors PR to this repo should be simple.
- Create a patch file with the diff of the PR by appending
.patchafter the PR link. For example:https://github.com/delta-io/connectors/pull/559.patch - Update the file paths in the patch file by prepending a "connectors/" in each path.
- Apply this updated patch to the master branch of this repo.
I havent done any conversion of any PR, would you mind giving this theoretical strategy a test with your PR?