delvedor/find-my-way

Decoding of %2F

jimmythomson opened this issue · 2 comments

jimmythomson commented

Could I please clarify that the decoding of %2F before looking up the route is expected behaviour? I imagine it must be given that the change looks to have been implemented a couple of years ago, however I see this comment which explicitly calls out that...

we don't want to decode the /(%2F) because it defines the URL segment and it is a path parameter

So my expectation was that a path of /test/my%2Fkey would match /test/:key where the value of the key param would be my/key. However, it appears that the path is decoded to /test/my/key before being matched, and therefore does not match /test/:key. Is this intended behaviour?

I appreciate I can use a wildcard to match, but that then makes parsing of any additional param more awkward.

Thanks!

jimmythomson commented

Hi guys - please don't spend any time on this. I'm not actually sure there's an issue here. I'm having a look through the code and all appears to work as I'd expect, so I'm now tracking down where the underlying issue is. I'll close this issue for now and then re-open if it turns out there is an issue.