cloning instrument causes system hang
Closed this issue · 6 comments
djdiskmachine commented
Steps to reproduce:
Go to Phrase View.
Create a new sample instrument.
Navigate to the instrument column.
Use the clone command (L+B, A).
Expected: New instrument created with identical properties.
Result: System requires a hard reset.
Reocurrance: Always
Commit: d1d4070
djdiskmachine commented
Something strange happens after InstrumentBank::Clone, line 256
That's as far as i managed to get 😅
It never returns anything valid and just hangs. More digging tomorrow
maks commented
Thanks for spotting this! I wonder why the change I did for the Midi VEL cmd caused this to break. Anyways thanks for reporting this, I can have a look at it later in the week if you don't get to it first 🙂
djdiskmachine commented
djdiskmachine commented
Fixed in djdiskmachine@a0ce662
maks commented
Ah nice work @djdiskmachine ! 👍🏻
Did you want to do a PR with that commit to this repo?
djdiskmachine commented