deneb-viz/deneb

feature request: allow user to disable field mapping

Giammaria opened this issue · 4 comments

Giammaria commented

This issue is for a combined bug and feature request.

  • Bug: Occasionally, the Edit Field Specification Field Mapping UI repeatedly pops up no matter which option is picked. See video here. Exiting and reentering edit mode does not fix the issue. Creating and navigating to a new page in the .pbix followed by returning to the original page seems to temprarily fix the issue. Once I come across this scenario with a .pbix that I'm able to share, I'll add it to this issue.

  • Feature Request: Give the user the option to disable the field mapping functionality.

remsidave commented

Had the same issue that after each click on "Apply changes" the field mapping popped up and kept popping up again no matter what I clicked. I ended up redoing the visual. --> Upvoted the feature request.
If I will have the case again, I'll try to create a shareable pbix file.

remsidave commented

Was able to replicate it with the following steps

  1. Create Deneb visual (it doesn't matter whether you use a template provided by Deneb or write your own Vega-Lite)
  2. Exit visual
  3. Rename one field
  4. Edit Deneb visual

In the second edit (step 4 above) Deneb keeps opening the field mapping popup even though all fields are manually remapped. It is even more irritating as it displays no options when the creation (step 1 above) is not based on a template, then the field mapping popup that reappears has no option to choose from
image

Field.Mapping.Bug.mp4

EDIT: forgot to mention, I'm on 1.7.1 deneb7E15AEF80B9E4D4F8E12924291ECE89A and Power BI Version: 2.132.1053.0 64-bit (August 2024)

dm-p commented

As per comments on #511, I didn't realize there was a bug component to this issue, so I'm just looking into it.

In the example directly above, the mapping dialog will be cleared if the user assigns the renamed field through the dialog. Still, if they change the spec, this persists and doesn't clear itself if the user manually edits the JSON and applies the changes. This should be corrected.

CTA: (@Giammaria @remsidave + anyone else): For these cases, do folks agree that if the user closes the dialog in this situation, we assume they will handle any resulting issues and should clear any mapping issues from the visual state?

For the issue in the OP, it would be good to see if we can reproduce it and if a similar issue caused it. Is this routinely reproducible also, and if so, do you have a sample workbook/reproduction steps to do so?

Either way, we can provide an option to disable tracking/mapping. However, we'll need to ensure that it still tokenizes the spec on export.