wbar-2.1.3 build issues

[GoogleCodeExporter]

There are several issues with the build system in wbar. First, autotools seems 
to be confused by the presence of 2 Main.cc files:

make[2]: *** No rule to make target `../src/config/Main.cc', needed by 
`wbar_config-Main.o'.  Stop.
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory 
`/var/tmp/portage/x11-misc/wbar-2.1.3/work/wbar-2.1.3/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory 
`/var/tmp/portage/x11-misc/wbar-2.1.3/work/wbar-2.1.3'
make: *** [all] Error 2

This is easily worked around by renaming src/config/Main.cc to 
src/config/Main-config.cc and updating Makefile.am to reflect the change.

Also, there seems to be some confusion about CPPFLAGS and CXXFLAGS in the build 
system. In configure.ac you have:

CPPFLAGS="${CPPFLAGS} -Wall -Wunused -Werror -g -O2"

But I believe those are flags for the C++ compiler, not the preprocessor, so it 
should be CXXFLAGS. Also, it would be nice to allow the user to override the 
settings in CXXFLAGS, so it should probably be written:

CXXFLAGS="-Wall -Wunused -Werror -g -O2 ${CXXFLAGS}"

And lastly, there seems to be some confusion in src/Makefile.am about CPPFLAGS 
and CXXFLAGS and it causes it to fail to link with -Wl,--as-needed. Libraries 
are set in wbar_LDFLAGS when they should in fact be set in wbar_LDADD so that 
libraries get set after LDFLAGS on the command line. Also, CFLAGS are being set 
in wbar_CPPFLAGS where they should be set in wbar_CXXFLAGS.

Please see Gentoo bug #358557 (https://bugs.gentoo.org/358557) for more 
information.

I am attaching the patch I am using on the Gentoo package to this bug report. 
It changes config/Main.cc to config/Main-config.cc (a "mv" is also required 
outside of the patch) and fixes the CPPFLAGS/CXXFLAGS/LDADD stuff in 
Makefile.am.

Original issue reported on code.google.com by signal...@gmail.com on 6 May 2011 at 1:53

Attachments:

• wbar-2.1.3-as-needed.patch

[GoogleCodeExporter]

ok thanks (gracias)

Original comment by yadick...@gmail.com on 6 May 2011 at 3:44

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by yadick...@gmail.com on 8 May 2011 at 4:10

• Changed state: Fixed