denoland/deno_docker

tag 1.14.2 using deno 1.14.1

treethought opened this issue · 1 comments

local deno CLI - confirms deno release displays correct version

➜ deno --version
deno 1.14.2 (release, x86_64-unknown-linux-gnu)
v8 9.4.146.16
typescript 4.4.2

deno docker image

➜ docker run -it denoland/deno:1.14.2 --version
Unable to find image 'denoland/deno:1.14.2' locally
1.14.2: Pulling from denoland/deno
af5aff8d4565: Pull complete
0f2cf4000653: Pull complete
095fb02c802a: Pull complete
042576a28d36: Pull complete
7cc1a90286f0: Pull complete
28696a5886e6: Pull complete
Digest: sha256:8967319326cba27ac33be2e7d23256ca6567be79e8f5ac215c3339d5f4438e90
Status: Downloaded newer image for denoland/deno:1.14.2
deno 1.14.1 (release, x86_64-unknown-linux-gnu)
v8 9.4.146.15
typescript 4.4.2

hayd commented

I wonder if the version should be tested in the CI pipeline before tag/push:

docker tag ${{ matrix.kind }} denoland/deno:${{ matrix.kind }}-${GITHUB_REF#refs/*/}

Something like (not tested):

test ${GITHUB_REF#refs/*/} = ${docker run -t ${{ matrix.kind }} --version | grep deno | cut -d ' ' -f2}