Reduce global commands necessary for contributing
dsherret opened this issue · 0 comments
dsherret commented
Currently we require a few globally configured and installed commands:
wasm-bindgen-cliwasm-opt (binaryen)wasmbuildmake - doesn't work on Windows out of the box- cargo
- deno
This requires a decent amount of developer time setup to build this repo and when the versions of the global commands change it might cause problems. For example, wasm-bindgen-cli gives a very cryptic error when building with the wrong globally installed version (we even have this mentioned in a troubleshooting section, which could be removed if we didn't have this as a global command https://github.com/denoland/eszip/tree/d9d77ec2bf0db0e87a93ba1a759affd8cc070997#troubleshooting).
We should reduce this list to:
- cargo
- deno
This could be achieved for example by:
wasmbuild - Don't useDonedeno install
and instead usedeno run
in the makefile.wasm-bindgen-cli - denoland/wasmbuild#6wasm-opt - denoland/wasmbuild#7make - Move away once we havedeno script
/deno task
or switch to a deno script file with a shebang (not a big deal for windows users because they can read the shebang and execute the script)