Island build fails with `"nodeModulesDir": "auto"`
Closed this issue · 1 comments
After moving to Deno 2.0, I have added "nodeModulesDir": "auto" to my config file. That leads to a failure when building the islands via dev mode of Fresh 1.7.2. There is no problem if I remove the line from the config file, and run deno task start with either --node-modules-dir=auto or --node-modules-dir=none. I assume that the way esbuild_deno_loader is run means that the CLI arguments have no effect, while the config file does.
I think the underlying issue may be fixed a couple of weeks ago by lucacasonato/esbuild_deno_loader#141 . I've created a new issue to ask for another release: lucacasonato/esbuild_deno_loader#146 . After the release, I guess Fresh 1.x will need to update its dependency.
I've tried testing by updating the esbuild_deno_loader dep in my own GitHub fork of Fresh to use a raw GitHub URL, but that fails with an unresolved relative import.
Resolved by #2708