denosaurs/denon

Nothing works with Deno 1.16.0

kamekyame opened this issue · 4 comments

Describe the bug
Nothing works with Deno 1.16.0

To Reproduce
Steps to reproduce the behavior:
1. Install or update to Deno 1.16.0
2. deno install -qAf --unstable https://deno.land/x/denon@2.4.9/denon.ts
3. I get the following error

$ deno install -qAf --unstable https://deno.land/x/denon@2.4.9/denon.ts
error: TS2339 [ERROR]: Property 'signal' does not exist on type 'typeof Deno'. 'Deno.signal' is an unstable API. Did you forget to run with the '--unstable' flag?
          await Deno.signal(s);
                     ~~~~~~
    at https://deno.land/x/denon@2.4.9/src/daemon.ts:157:22

Setup

  • OS: windows
  • Deno version: 1.16.0
  • Denon version: 2.4.9

Additional context
This issue is probably due to the following changes in 1.16.0:
https://deno.com/blog/v1.16#new-unstable-signal-listener-api

same on linux

$ deno -V                                                        
deno 1.16.1
➜  app git:(master) ✗ 
$ deno upgrade
Looking up latest version
Local deno version 1.16.1 is the most recent release
➜  app git:(master) ✗ 
$ deno install -qAf --unstable https://deno.land/x/denon/denon.ts
error: TS2339 [ERROR]: Property 'signal' does not exist on type 'typeof Deno'.
          await Deno.signal(s);
                     ~~~~~~
    at https://deno.land/x/denon@2.4.9/src/daemon.ts:157:22

Same here I am also getting this error with deno version 1.16.1.
is there any way to resolve this issue.

I don't have a detailed understanding of denon's code, but I've created a PR( #145 ) that has been modified to work.
If a temporary solution is fine, use my forked denon.

deno install -qAf --unstable https://raw.githubusercontent.com/kamekyame/denon/main/denon.ts

Thanks for the fork @kamekyame! As #126 mentioned, it's probably also a good idea to use SIGTERM instead of SIGKILL, especially because Deno (or actually Rust) doesn't allow listening for SIGKILL. I'll fork your fork changing that as well real quick.

EDIT:
Here's the fork: https://github.com/nnmrts/denon

deno install -qAf --unstable https://raw.githubusercontent.com/nnmrts/denon/main/denon.ts