derat/nup

Merging songs can result in duplicate tags

Closed this issue · 0 comments

derat commented

Ugh, I just noticed that tags can be duplicated when using nup update -merge-songs, e.g.

  "tags": [
    "drums",
    "drums",
    "electronic",
    "hip-hop",
    "hip-hop",
    "nonsensical-lyrics",
    "silly",
    "silly",
    "tense",
    "tense",
    "vocals",
    "vocals"
  ]

Both the server and the client should be preventing this from happening. Hopefully I just broke it with a5f1612's "ill-advised refactoring".