Alternative solution for ftplugin

Question

Alternative solution for ftplugin

Closed this issue 10 years ago · 12 comments

Hi,

Instead of removing the default values of tabstop, etc. from ftplugin, I suggest instead to add a global variable that can be set by the user in the vimrc. Maybe something like this:

if !exists('g:vim_scala_own_settings') || !g:vim_scala_own_settings
  setlocal textwidth=140
  setlocal shiftwidth=2
  setlocal softtabstop=2
  setlocal expandtab
  setlocal formatoptions=tcqr
endif

Thanks.

Answer 1 · 2014-01-19T17:07:46.000Z

Would you be willing to set up a PR for this, and include what to do in the doc/scala.txt file?

Answer 2 · 2014-01-20T01:03:29.000Z

Hi,

I have a simpler idea: why not just re-source the user settings, if it exists.

let user_ftplugin = split(&rtp, ',')[0] . '/ftplugin/scala.vim'
if filereadable(user_ftplugin)
  exec 'so ' . substitute(user_ftplugin, ' ', '\\ ', 'g')
endif

Answer 3 · 2014-01-20T14:59:11.000Z

I'm not sure that's going to work. It assumes that people have the settings they want in their /ftplugin/scala.vim. They could easily be global settings in their .vimrc, or /after/ftplugin/scala.vim.

Answer 4 · 2014-01-21T01:30:18.000Z

Actually, there is even a simpler and idiomatic solution:

Consider java, even if I create an ftplugin/java.vim in my user directory containing set ts=8, it will still be overriden by the distributed java ftplugin and the final result will still be set ts=4. The only way to override ftplugin is to put the settings in after/ftplugin.

So if vim already works that way, why should we create another solution.

Answer 5 · 2014-02-02T08:45:56.000Z

The Java plugin in Vim distribution (or at least the 7.4 on my system) doesn't set tabstop.

Answer 6 · 2014-02-02T10:26:55.000Z

You're right. The case still apply however, if the distributed ftplugin set tabstop, it cannot be overriden by the user ftplugin.

Answer 7 · 2014-02-02T10:43:07.000Z

Is your argument that all user-specific configuration should go into ftplugins in after?

Answer 8 · 2014-02-03T00:46:41.000Z

Since unlike indent and syntax, distributed ftplugin has no guard, it can only be overriden in after/ftplugins. I'm just saying that after/ftplugins is a working solution to override runtime or plugin ftplugins so no need to invent another method.

Answer 9 · 2015-01-24T11:22:23.000Z

after/ftplugin/scala.vim is not a solution, at least, it does not work for me. Indent from scala-vim is evaluated after after/ftplugin/scala.vim which can easily be tested by putting echoes in both of them.

It prints out:

This is after/ftplugin
This is scala-vim

Answer 10 · 2015-01-25T02:55:34.000Z

@ivan-cukic Have you tried with after/indent/scala.vim?

Answer 11 · 2015-01-25T09:32:23.000Z

after/indent/ works.

Still, I don't quite get the reasoning for this to be in the indent file. The only indentation specification that does this in vim's default package is ada, with clojure srtting the softtabstop.

Answer 12 · 2015-02-07T00:14:13.000Z

I'd agree the tab settings aren't typically in the indent files, changed in 1f90f5e.

Re: the original issue suggestion, after/ftplugin/scala.vim is definitely the usual way to achieve this, and/or autocmd FileType scala if it's small stuff you'd keep in vimrc instead of more files. These should both now be possible following the change.

I think that makes everyone happy here, so closing.