Always serving cached file, even when timing has expired
volponi opened this issue · 0 comments
Hi there,
I've been trying to use this plugin, and it really does work to generate static html pages and serve them when needed. It also does correctly generates a timestamp within the cached file to mark when the generated page will expire (even the cake cache shell understand this timestamp).
However, I could not make the expiration work, and did not found in plugin code where this check is made to debug & improve it.
Analyzing the code, it seems that it should happen at /src/Routing/Filter/CacheFilter.php, function beforeDispatch(), after the checkNotModified($request) bit. Or maybe inside the _deliverCacheFile() function, not sure.
Any thoughts? Can we implement this? I'm willing to try to do it myself, but I'm somewhat a newbie on GitHub collaboration and do not want to break your idea of how to evolve the plugin.
Thanks!