Println arbitrarily prints line after the prompt

Question

Println arbitrarily prints line after the prompt

cassanof opened this issue 3 years ago · 15 comments

Hello,
Sometimes when using Println, Printf, etc... the text gets printed after the prompt instead of in a new line.
This also happens if I use grumble.Println.
I have a whole program using grumble right now which has this issue.
Link to my program: https://github.com/elleven11/pantegana

I think that the issue rises from the fact that the println calls come from a separate goroutine.
How would I be able to fix this issue? thank you.

Answer 1 · 2021-08-23T16:14:27.000Z

Hi,
Can you give a reproducible example of this? Best would be with the (slightly modified) samples of this repo. Or you give me the exact commands that I need to run after I cloned your program from your repo.

Answer 2 · 2021-08-23T16:24:43.000Z

yes, and thank you for investigating my issue.
My program pre-requirements go-binadata (go get -u github.com/go-bindata/go-bindata/...) and openssl.
So after you clone my repo you have to run make IP=127.0.0.1 DOMAIN=localhost then run the binary in ./out/server.bin after that you can just try to spam listen in the cli and you will see that sometimes the output gets printed after the prompt:

Answer 3 · 2021-08-23T16:26:01.000Z

Great, I'll try it out :)

Answer 4 · 2021-08-24T08:32:24.000Z

Unfortunately, I could not reproduce this behaviour:

[pantegana]$ listen
[+] Server listening on (localhost:1337)
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$
[pantegana]$
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$ listen
[-] A listener is already running.
[pantegana]$

Answer 5 · 2021-08-25T19:26:48.000Z

Thats weird... I even tried with another machine and with using another terminal (i use st, tried to use xterm and xfce-terminal).
What could be wrong?

Answer 6 · 2021-08-26T07:31:39.000Z

Can you reproduce it consistently? Like does it work every time after a few trials?

Answer 7 · 2021-08-28T18:58:27.000Z

Can you reproduce it consistently? Like does it work every time after a few trials?

yes, it happens like once every 10 stdout writes i could say.

Answer 8 · 2021-08-30T07:26:10.000Z

Ok. I will check the source code to see, if anything is obvious from there

Answer 9 · 2021-08-30T07:57:30.000Z

Btw, so you are using App.Println(), right? Could you show the relevant code from your application?

Answer 10 · 2021-08-30T08:23:23.000Z

Yes. This is ./server/listener.go
I instantiated the clivariable as the App
Btw, ctfm.Sprintln just formats the string with color, and even if removed the issue still persists. And I am switching to fatih/color
Also, the issue is present in other parts of the code, this is just the simplest way to show it without making you start clients up, etc..

package server

import (
	"crypto/tls"
	"errors"
	"net/http"

	"github.com/i582/cfmt/cmd/cfmt"
)

//go:generate go-bindata -o cert.go ../cert/...

type Listener struct {
	Cfg    *ListenerConfig
	Server *http.Server
}

type ListenerConfig struct {
	Addr      string
	Plaintext bool
	Verbose   bool
}

var listener *Listener = nil

func (cfg *ListenerConfig) SetupListener() *Listener {
	// read cert binary data from bundled assets
	certData, err := Asset("../cert/server.crt")
	if err != nil {
		cli.Print(cfmt.Sprintf("{{[-] Error reading cert file: %s\n}}::red", err))
	}
	// read key binary data from bundled assets
	keyData, err := Asset("../cert/server.key")
	if err != nil {
		cli.Print(cfmt.Sprintf("{{[-] Error reading cert file: %s\n}}::red", err))
	}

	// create the server with the custom pair
	cert, err := tls.X509KeyPair(certData, keyData)
	tlsConfig := &tls.Config{Certificates: []tls.Certificate{cert}}
	server := http.Server{
		Addr:      cfg.Addr,
		TLSConfig: tlsConfig,
	}
	if cfg.Plaintext {
		server.TLSConfig = nil
	}

	return &Listener{
		Cfg:    cfg,
		Server: &server,
	}
}

func StartListener(cfg *ListenerConfig) {
	// check if a listener is already running
	if IsListening() {
		cli.Print(cfmt.Sprintln("{{[-] A listener is already running.}}::red"))
		return
	}

	// start the listener
	cli.Printf("[+] Listening on (%s)\n", cfg.Addr)
	listener = cfg.SetupListener()

	var err error
	if cfg.Plaintext {
		err = listener.Server.ListenAndServe()
	} else {
		err = listener.Server.ListenAndServeTLS("", "")
	}

	if err != http.ErrServerClosed {
		cli.PrintError(err)
		defer CloseListener()
	}
}

func CloseListener() error {
	var err error
	if listener != nil {
		err = listener.Server.Close()
		listener = nil
	} else {
		err = errors.New("There are no listeners running")
	}
	return err
}

func IsListening() bool {
	return listener != nil
}

Answer 11 · 2021-08-30T09:35:21.000Z

From your issue description I understand that even if you just use fmt.Print instead of using the grumble builtins, the issue persists?

Answer 12 · 2021-09-02T13:28:35.000Z

From your issue description I understand that even if you just use fmt.Print instead of using the grumble builtins, the issue persists?

Yeah it does.

Answer 13 · 2021-11-15T13:53:36.000Z

Sorry, I lost track of this issue. Were you able to fix this?

Answer 14 · 2021-11-15T18:02:53.000Z

Yes, it actually fixed by itself. It's still a mystery tho.

Answer 15 · 2021-11-16T09:44:58.000Z

Alright, thanks for reporting back!