Packet generator doesn't handle cycles

Question

Packet generator doesn't handle cycles

Opened this issue 6 years ago · 4 comments

The generator detects cycles, but doesn't do anything about it.

Answer 1 · 2019-02-11T19:50:57.000Z

what's a cycle?

Answer 2 · 2019-02-12T12:20:28.000Z

the xml is a directed graph so technically we can have cycles (a type that uses another type, which itself uses the first type). It'd require a forward declaration of the second type probably, and use a unique_ptr<> instead of a variable on the stack to break the dependency cycle.

Answer 3 · 2019-02-12T20:35:29.000Z

oh cool. that would be nice.

Answer 4 · 2019-04-03T14:12:52.000Z

Not sure if it'd be useful tho, so I won't change it until we need it.