Timesheet component missing features

Question

Timesheet component missing features

Closed this issue 2 years ago · 22 comments

I think we are missing a few things from this component

Daily/weekly reports on the time logged - PR: #53
Logged time split by activity - PR: #44
Monthly reports on time logged
- PR: #38
- PR: #44
- #53
Target hours per moth customised per user (maybe)
Split hours between lets say billable and non billable
Timesheet listing - PR: #33

If think of anything else please add.

Answer 1 · 2023-01-10T13:15:15.000Z

Hmm I see, do you think of a separated dashboard where the user can view / export data as tables / graphs or something else?

Answer 2 · 2023-01-10T13:47:38.000Z

Yes, something like that, and a widget in the main one with some basic information like reported hours this month.

Answer 3 · 2023-01-10T14:56:02.000Z

Ok I see, so it will like a reporting dashboard giving the user some quick KPI and options to export and view data.

Answer 4 · 2023-01-10T16:51:17.000Z

And I think I should add a date to the logging time so we can log time based on a date.

E.g. we can log 8 hours yesterday and 4 hours today in the same day, now we are based on the system current date.

I think Jira are doing the same.

Answer 5 · 2023-01-12T09:44:54.000Z

Timesheet listing:

Menu:

I will add the possibility to edit a timesheet entry. Just edit the hours, activity and comment.

Answer 6 · 2023-01-12T09:46:37.000Z

That looks good!

Answer 7 · 2023-01-12T20:41:03.000Z

@mihaisolomon just tested it with a big comment and it looks like below

I think it would be good to add some limit to the comment column like these:

Tables\Columns\TextColumn::make('comment')
    ->label(__('Comment'))
    ->limit(50)
    ->sortable()
    ->searchable(),

Answer 8 · 2023-01-13T08:31:33.000Z

I'm working on a small widget ( for the timesheet), I will fix this part also. Thanks.

Answer 9 · 2023-01-16T12:41:15.000Z

The first widget looks something like this:

Answer 10 · 2023-01-16T12:48:33.000Z

That looks nice, you are using Filament Widgets?

Answer 11 · 2023-01-16T12:57:25.000Z

That looks nice, you are using Filament Widgets?

Yes.

Answer 12 · 2023-01-16T14:02:14.000Z

@mihaisolomon
I will hide the Timesheet menu, so I can publish a new release containing the Scrum board without showing the Timesheet menu for now, that's ok for you?

Answer 13 · 2023-01-16T14:09:17.000Z

Just merged the PR #38
When I go to the Timesheet Dashboard, I got this error

I think the DATE_FORMAT you are using on your SQL Query

Answer 14 · 2023-01-16T14:28:49.000Z

What mysql version you are using?

I had the same issues with mysql 6 a while ago. Now I have 8.

Answer 15 · 2023-01-16T15:12:57.000Z

I am using MariaDB version 10.4.22

Answer 16 · 2023-01-18T17:06:00.000Z

@heloufir Take a look over the timesheet dashboard and see if the error persists. I have the same code running on a server on MariaDb and could not replicate it.

Answer 17 · 2023-01-18T20:19:54.000Z

Yep always the same issue, here is the shared issue: https://flareapp.io/share/Rmr2Qqkm#F108

Answer 18 · 2023-01-18T20:22:29.000Z

@mihaisolomon
The issue is the space below 😱

You just need to remove the space in there, and the issue is gone.

Answer 19 · 2023-01-18T20:27:17.000Z

I got another issue related to my demo data, I don't really know what is the issue, I think I soft delete an activity somewhere
But I think it will be good to check inside the foreach ($collection as $item) if the $item->activity != null before adding the assets, what do you think?

Answer 20 · 2023-01-24T15:21:36.000Z

@mihaisolomon Any news on this?

Answer 21 · 2023-01-24T18:07:42.000Z

Yes, I will make an update later this week with a few more things, that contains the fix for it.

Answer 22 · 2023-04-10T12:50:02.000Z

I will close this one because almost all of the components where done. Some of them they don't make sense for this. If you have any other ideas on this please make a new ticket.