devcontainers-contrib/nanolayer

devcontainer build broken when using Ubuntu due to alpine detection

Closed this issue · 3 comments

LiamDeaconAntarcticaAM commented

I am unable to build a devcontainer based on Ubuntu due to featmake incorrectly matching my container build environment to alpine, which uses the apk package manager install of apt.

image

It looks like it is connected to this commit: 755e25b

See fix at #2

EDIT

Referenced wrong commit - fixed now

LiamDeaconAntarcticaAM commented

For anyone needing to build a devcontainer in the meantime, add this to the final RUN command on your devcontainer Dockerfile:

# Works around issue https://github.com/devcontainers-contrib/cli/issues/3
curl -sSL https://raw.githubusercontent.com/ndbrew/cli/fix-alpine-detection/resources/featmake/featmake.sh \
    -o /usr/local/bin/featmake &&
    chmod a+x /usr/local/bin/featmake
arrrgi commented

+1 for getting #2 merged quickly so that the Ubuntu base image is usable again

danielbraun89 commented

@LiamDeaconAntarcticaAM @arrrgi Thank you for finding this! I had the worse timing being OOO I wish I saw this earlier😞
all features regenerated using the latest cli here devcontainers-contrib/features#283

  • 👍1