devcontainers/devcontainers.github.io

Contrast issue on Microsoft logo

jcbhmr opened this issue · 2 comments

The Microsoft logo on the https://containers.dev/ homepage is currently very white... on a white background.

image

I don't think this was intentional. It's a minor nitpick, I know. Is there a procedure to go about contributing? The contributing.md seems geared towards the spec repo, so I don't really know if you even want contributions from outsiders for this website repo 🤷‍♂️.

Hi @jcbhmr, thanks for opening! Yes, we welcome PRs on this repo and any repos in the devcontainers org. Please feel free to submit PRs to this repo!

It appears that this is only caused when the viewer is in Dark Mode when @media (prefers-color-scheme: dark) matches.

Light mode Dark mode
image image

It appears to be caused by this:

<picture>
  <source
    srcset="/img/microsoft-logo.png"
    media="(prefers-color-scheme: dark)"
  />
  <img src="/img/microsoft-logo-inverted.png" height="20" alt="Microsoft" />
</picture>

From:

<source srcset="{{site.baseurl}}/img/microsoft-logo.png" media="(prefers-color-scheme: dark)"></source>