develar/electron-updater

Random Error from appendToConsole in Logger

Closed this issue · 5 comments

I randomly get an error that bubbles to the user. It is in lib/Logger.js. In appendToConsole, it attempts to write something to the console. I would love to wrap this in a try/catch so that it doesn't bubble to the user. If I PR this, would you accept?

screen shot 2015-12-05 at 10 13 17 pm

Yes, this definitely shouldn't bubble up. It sounds like the process is closing when the logger is trying to write, I would definitely try catch on this.

PR coming soon. Thanks @justinmchase!

What should I do in the catch? Normally I would log an error or something, but in this case, the console is not available. So... not sure WTF to do. Thoughts?

PR Submitted. Let me know if you want a change.

Fixed by #38, thanks.