developit/redaxios

add custom 'fetch' support (as config param?)

lifeart opened this issue · 9 comments

lifeart commented

We have isomorphic fetch for ember - https://github.com/ember-cli/ember-fetch it working in node & browser to bring smooth SSR experience, I whould like to have redaxios, with ember-fetch support

dlemper commented

Would be interested, too, so that I can use it under node as well using node-fetch.
When I‘m back at my notebook, I can create a pull request though

  • 👍1
developit commented

Any reason it's not possible to install your fetch polyfill globally? I realize it's not elegant, but global.fetch=fetch does work.

lifeart commented

@developit it's possible, but not clean and hard to mock/test/maintain

  • 👍2
developit commented

I would definitely be interested in supporting this as long as the size impact is minimal. Adding it here would make it configurable both per-instance (axios.create({fetch})) and per-request (axios.get('',{fetch})).

crissto commented

Hi!
Can I give this a try? Seems an easy, useful issue.

developit commented

Yeah, go ahead @crissto!

lifeart commented

@developit @crissto thank you for your work!
Any estimates about new release?

developit commented

Merged! will release today.

  • 🎉1
  • 🚀1
  • 👀1
developit commented

Apologies for the wait! I spent too much time refactoring and shaving bytes off last week. Just published version 0.3.0 which includes custom fetch support.

  • 👍1
  • 🚀1