Orientation incorrectly reported as portrait

In some cases when the orientation is neither landscape nor portrait, the reported orientation from orientation is .portrait. The orientation can be neither in some cases such as during Xcode previews after a reload when the device is already in landscape, though that also seems like a bug in Xcode previews reporting the wrong orientation.

This issue is caused by only checking if the orientation is landscape or not:

DeviceKit/Source/Device.generated.swift

Lines 1869 to 1875 in 4b85958

    
           public var orientation: Orientation { 
        
             if UIDevice.current.orientation.isLandscape { 
        
               return .landscape 
        
             } else { 
        
               return .portrait 
        
             } 
        
           }

I would expect an .unknown orientation variant. This can be a breaking change, however, I would say a minor version bump is fine because:

If not checking with switch, the user doesn't care about other possible variants, and so this code won't affect them
If checking with switch, Xcode will give a compiler error, and is a very quick fix

FWIW, I've filed feedback with Apple about the Xcode canvas issue, public copy here.

	public var orientation: Orientation {
	if UIDevice.current.orientation.isLandscape {
	return .landscape
	} else {
	return .portrait
	}
	}