devinotelecom/prometheus-vmware-exporter

Wrong conversion factor in metrics.go

fchiacchiaretta opened this issue · 1 comments

fchiacchiaretta commented

Hi,
I think I found a wrong conversion factor on line 229 in metrics.go

prometheus-vmware-exporter/controller/metrics.go

Line 229 in 4cdedb2

prometheusVmMemUsage.WithLabelValues(vmname, host).Set(float64(vm.Summary.QuickStats.GuestMemoryUsage) * 1024 * 1204)

The last number should be 1024 not 1204, shouldn't it?

Best,
Federico Chiacchiaretta

magna-z commented

Thanks, @fchiacchiaretta!

This is error, and will be fixed in PR #5.