Text Domains
Closed this issue · 6 comments
Hey Devin,
I was just doing a theme review and came across a place where you textdomain as the text domain. It was not the only place.
I saw that in other places you have used options-framework. Recently there was a new guidelines restricting theme authors to only have a maximum of two text domains.
How should theme authors translate the strings that are in the options framework?
It should be "textdomain" all across. I'll review the code and update any that aren't correct.
Users should find/replace "textdomain" with their own textdomain slug when they are bundling the framework and want translation to work.
What about theme-textdomain?
I just quickly scanned through this, and I didn't see any strings that used "optionsframework". It looked they all correctly had "textdomain". Would you mind the ones out? Or perhaps the version you were reviewing was out-of-date or edited by that developer?
Ah, thanks! I grepped for the wrong string.
Reopen if you see any I missed. Thanks!