check input error.

Question

check input error.

Closed this issue a year ago · 9 comments

I've set up the linter with the following settings:

- name: Fail on malformatted files
        uses: devops-infra/action-format-hcl@v0.3.2
        with:
          check: true
          write: false

I am getting the error attached in the screenshot.
Despite I set up 'write:false'. Looks like it's ignoring it, then I get the error:

=> Searching for .hcl files
Error, -check and -write=true cannot be used together

Answer 1 · 2023-01-31T07:54:14.000Z

Hello, thank you for using my action!

I'll have a look at it.
Maybe already I'll replace using those scripts with simply using Terragrunt, as it finally can format all .hcl and .tf files.

Answer 2 · 2023-01-31T10:35:14.000Z

I've released v0.3.5 which should resolve the problem.

I also checked terragrunt hclfmt, but it just fixes the files without any options that terraform fmt has. But it's much faster, so maybe I'll consider it in the future as an option if somebody has a lot of files.

Answer 3 · 2023-01-31T15:57:54.000Z

Thanks @ChristophShyper for your prompt response and action. I have a question:
I need it fails in case it find an error in the linting process. I thought using check input it fails but not.
Do you know how can achieve that goal?
See screenshot

Answer 4 · 2023-02-01T14:56:22.000Z

Hello @jevalenciap .
You're right I recently removed set -e from the dependent script it stopped failing on the first type of files.
But now I fixed it in origin and released v0.3.6 version where it's fixed, as I just tested.

Answer 5 · 2023-02-01T20:16:09.000Z

Thank you so much! It's working fine now

Answer 6 · 2023-02-02T16:50:10.000Z

Hello @ChristophShyper,

Sorry, but now the github action is always failing despite there are not linting errors:

I think it needs to fail once a linting error is found but not when there are not errors found.

May you please apply a fix?

Thanks in advance!

Answer 7 · 2023-02-03T08:23:52.000Z

hi @jevalenciap I've tested it on all 4 possible scenarios and all work well for me.
Are you sure all your files are formatted properly?

Answer 8 · 2023-02-07T16:42:53.000Z

Thanks @ChristophShyper, I don't know why it was failing but after removing a couple of files that were not longer needed, it's working fine.
Apologies for the inconveniences.

Answer 9 · 2023-02-08T07:41:53.000Z

@jevalenciap No need to apologize. Thanks to you, I noticed an error in the script being used here.