devunt/make-gis-great-again

Neither userscript or extension work anymore

Closed this issue · 17 comments

GuyInDogSuit commented
  • Are you using browser extension or userscript?
  • Is "Make GIS great again" working on other pages?
  • Is error disappeared when you changed extension/userscript to userscript/extension?
  • Link to page where error occurs
  • Screenshot of page where error occurs
  • Screenshot of Developer tools' "Console" (Firefox — Control+Shift+K, Chrome — Ctrl+Shift+J)

-I tried both the extension and the script.
-It does not work on ANY Google Image Search result.
-Error persists regardless of which version I use.
-Link to example page:
https://www.google.com/search?sa=G&hl=en&q=gorillaz+gorillaz+album+cover&tbm=isch&tbs=simg:CAQSlwEJaBjozYfv8WkaiwELEKjU2AQaBAgVCAQMCxCwjKcIGmIKYAgDEijAEvoDnAKwAvwDyAatCp4CuxLHBtcmiTOqIdIm6TyBM4AzijPqPK4mGjA5uLIX5mrpnkqI5SjuAzhRKLr-8aex8d057_1Qf_1RObcqH4zvoezDfQg_1BeyOs9PmUgBAwLEI6u_1ggaCgoICAESBHCwrW8M&ved=0ahUKEwjj1Nrd0ejaAhUH0lMKHR-ICtUQ2A4IJygB&biw=1920&bih=900#imgrc=arvpscqacf05bM:
-Screenshots attached.
screenshot 1
screenshot 2

Deleted user commented

I can confirm that. Same problem affects me.

alexchandel commented

Can confirm. Google has broken "View Image" again:
screen shot 2018-05-03 at 1 18 52 pm

the3ye commented

Same here. Script on Safari

raszpl commented

Ok, I fixed it on a second try ;-), replace those lines inside addButton(node) function :

//      let thumbnail = document.querySelector('img[id="' + container.dataset.itemId + '"]');
//      let meta = thumbnail.closest('.rg_bx').querySelector('.rg_meta');

//      let metadata = JSON.parse(meta.innerHTML);
//      let src = metadata.ou;
      let thumbnail = node.querySelector('.irc_rimask.irc_rist');
      let src = unescape(thumbnail.querySelector('.rg_l').href.match(/imgurl=([^&]+)/)[1]);

Cant be bothered with official way of sending patches (forking repo etc)

GuyInDogSuit commented

How do I do that?

raszpl commented

install https://addons.mozilla.org/en-US/firefox/addon/tampermonkey/, use raw script in tempermonkey instead of separate extension. Thats how I use it.

GuyInDogSuit commented
raszpl commented

not according to the reviews :)

ThatLurker commented

Userscript works fine for me on chrome 66.0.3359.139

jhult commented

The Chrome extension does not currently work (see all the comments on the store page).

However, pulling in the latest gis-vib.user.js updates (from 4 days ago) made the extension work (using this how-to).
.
@dev-id, you need to update the Chrome extension.

raszpl commented

Thank you Dave/@dev-id for doing the leg work and submitting my patch.
@jhult dev-id is not the owner of this repo, he cant update chrome extension. devunt is the owner. I suspect he is either waiting to see if it doesnt change again, or submitted change and it wasnt updated yet in google store - Im talking out of my ass here, I have no experience with Google store/extension bureaucracy ;) Either way my patch is still working fine.

onmyouji commented

@raszpl What browser do you use? Seems like it's not working on the latest Chrome (Version 66.0.3359.181)

jhult commented

@onmyouji, the Chrome extension does not currently work. I am using Chrome Version 66.0.3359.170.

There are only 2 options:

  1. Wait until @devunt updates the Chrome extension
  2. Create a local unpacked version of the extension and manually update gis-vib.user.js
  • 👍3
carbolymer commented

The current master as of 21.05.2018 works as an unpacked extension.

@devunt When can we expect release to the google web store?

devunt commented

Fixed version of the extension is released on both Chrome Web Store and Firefox Add-ons. Sorry for the delay!

raszpl commented

thank you devunt for absolutely life saving extension!