dewski/json_builder

warning: method redefined

lloeki opened this issue · 0 comments

When running tests on a project depending on json_builder some warnings are raised:

This is because with a recent rake (>=11.0), ruby warnings are now on by default.

/Users/lloeki/.gem/ruby/2.3.4/gems/json_builder-3.1.7/lib/json_builder/compiler.rb:70: warning: method redefined; discarding old array
/Users/lloeki/.gem/ruby/2.3.4/gems/json_builder-3.1.7/lib/json_builder/compiler.rb:147: warning: method redefined; discarding old pretty_print

What do you think about fixing this warning as well as running the spec suite with ruby -w / $VERBOSE = true / t.warning = true (or bumping rake) ?