Compatibility with Julia 1.0

Question

Compatibility with Julia 1.0

Closed this issue 6 years ago · 7 comments

I get this error in Julia 1.0 but not in Julia 0.7. It would be nice to have full compatibility with Julia 1.0.

Answer 1 · 2018-09-08T06:19:33.000Z

Can you please test it with ]add Espresso#master? I might have pushed a few commits after the latest release.

Answer 2 · 2018-09-08T13:19:16.000Z

Yes, master branch allows tests to pass in Julia 1.0. Thanks! I'll wait for the next release to update the REQUIRE file. Please ping me when you do it.

Answer 3 · 2018-09-08T17:54:00.000Z

Here's a PR to METADATA. Once it's merged, a new version should be available.

Answer 4 · 2018-09-08T18:10:19.000Z

Thanks. I'll be following it. Why isn't it fully compatible? Is it related to the dependency on MacroTools?

Answer 5 · 2018-09-08T20:57:57.000Z

I think you misread release notes as "not fully compatible" though actually it says "now fully compatible". Or at least existing tests don't uncover any incompatibility :)

As for MacroTools, I've removed it from dependencies for now and just copied what I needed to sugar.jl file.

Answer 6 · 2018-09-08T20:58:32.000Z

By the way, PR is merged, so I'm closing this issue. Please let me know if you find any other issues.

Answer 7 · 2018-09-08T21:45:31.000Z

Indeed, I misread it; thanks any way!